Add hardwareCursor setting #800
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ghoulr
commented
Jan 17, 2026
ghoulr
commented
- Added hardwareCursor top-level setting (configurable via /settings) to enable hardware cursor positioning for IME support.
- Added setUseHardwareCursor() in @mariozechner/pi-tui and wire it to /settings so changes apply immediately without restart.
badlogic
reviewed
Jan 17, 2026
| } | ||
|
|
||
| // Migrate useHardwareCursor -> hardwareCursor | ||
| if ("useHardwareCursor" in settings && !("hardwareCursor" in settings)) { |
Owner
There was a problem hiding this comment.
Why would there need to be a migration? useHardwareCursor was never in settings.
Contributor
Author
There was a problem hiding this comment.
Sorry, missed this AI slop in my cleanup job, GPT-5.2 created some complicated shit before, will check and clean again soon.
Owner
|
@ghoulr ah shit I fucked up. When I tested the change to the env var, I must have worked off of an old tui build, thinking hiding the cursor would still make IME work. Sorry! Left a small review, please amend. |
ghoulr
force-pushed
the
feat/add-hardware-cursor-settings
branch
from
83da838 to
268d597
Compare
Owner
|
Cheers, I've manually merged this and made some more adjustments.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.