Skip to content

Conversation

@rickhanlonii
Copy link
Member

Stacked on #35497


Now that the assert helpers require a component stack, we don't need the {withoutStack: true} option.

@meta-cla meta-cla bot added the CLA Signed label Jan 12, 2026
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jan 12, 2026
@react-sizebot
Copy link

react-sizebot commented Jan 12, 2026

Comparing: d290875...7a7c074

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 608.73 kB 608.48 kB = 107.65 kB 107.60 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 674.66 kB 670.95 kB = 118.59 kB 118.02 kB
facebook-www/ReactDOM-prod.classic.js = 694.11 kB 693.87 kB = 122.02 kB 121.97 kB
facebook-www/ReactDOM-prod.modern.js = 684.50 kB 684.25 kB = 120.42 kB 120.37 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 42.94 kB 42.82 kB = 7.78 kB 7.75 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 42.94 kB 42.81 kB = 7.78 kB 7.75 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 42.91 kB 42.79 kB = 7.75 kB 7.72 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.development.js = 42.80 kB 42.68 kB = 7.76 kB 7.73 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.development.js = 42.80 kB 42.67 kB = 7.76 kB 7.73 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.development.js = 42.77 kB 42.65 kB = 7.73 kB 7.70 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.production.js = 38.62 kB 38.50 kB = 7.17 kB 7.15 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.production.js = 38.61 kB 38.49 kB = 7.17 kB 7.14 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.production.js = 38.58 kB 38.47 kB = 7.14 kB 7.11 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.production.js = 38.49 kB 38.37 kB = 7.15 kB 7.13 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.production.js = 38.48 kB 38.37 kB = 7.15 kB 7.12 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.production.js = 38.46 kB 38.34 kB = 7.12 kB 7.09 kB
oss-experimental/react-dom/cjs/react-dom-profiling.development.js = 1,267.01 kB 1,262.88 kB = 210.59 kB 209.88 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js = 1,267.01 kB 1,262.87 kB = 211.37 kB 210.68 kB
oss-experimental/react-dom/cjs/react-dom-client.development.js = 1,250.46 kB 1,246.33 kB = 207.73 kB 207.01 kB
oss-experimental/react-art/cjs/react-art.development.js = 736.63 kB 734.08 kB = 115.79 kB 115.50 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js = 865.86 kB 862.57 kB = 134.79 kB 134.34 kB
oss-experimental/react-dom/cjs/react-dom-profiling.profiling.js = 753.57 kB 750.23 kB = 130.11 kB 129.57 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.js = 689.08 kB 685.36 kB = 122.10 kB 121.56 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 674.66 kB 670.95 kB = 118.59 kB 118.02 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.js = 571.49 kB 568.03 kB = 88.92 kB 88.36 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.js = 495.60 kB 491.86 kB = 78.72 kB 78.14 kB
oss-experimental/react-art/cjs/react-art.production.js = 361.64 kB 358.82 kB = 60.84 kB 60.39 kB

Generated by 🚫 dangerJS against 7a7c074

@rickhanlonii rickhanlonii changed the title [tests] remove withoutStatck from assertConsole helpers [WIP] [tests] remove withoutStatck from assertConsole helpers Jan 12, 2026
@rickhanlonii rickhanlonii changed the title [WIP] [tests] remove withoutStatck from assertConsole helpers [tests] remove withoutStatck from assertConsole helpers Jan 21, 2026
@rickhanlonii rickhanlonii changed the title [tests] remove withoutStatck from assertConsole helpers [tests] remove withoutStack from assertConsole helpers Jan 21, 2026
@rickhanlonii rickhanlonii merged commit e66ef64 into facebook:main Jan 28, 2026
234 checks passed
@rickhanlonii rickhanlonii deleted the asserts-stack-4 branch January 28, 2026 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants