-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore: Add System Info and Package Manager fields to bug template #18990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
| - npm | ||
| - yarn | ||
| - pnpm | ||
| - bun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deno 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add a "Other"? You'll never know what will come tomorrow
| id: package | ||
| attributes: | ||
| label: Which SDK are you using? | ||
| label: Where are you installing the Sentry SDK from? | ||
| description: | ||
| If you're using the CDN bundles, please specify the exact bundle (e.g. `bundle.tracing.min.js`) in your SDK | ||
| setup. | ||
| options: | ||
| - '@sentry/browser' | ||
| - '@sentry/node' | ||
| - '@sentry/node - express' | ||
| - '@sentry/node - fastify' | ||
| - '@sentry/node - koa' | ||
| - '@sentry/node - hapi' | ||
| - '@sentry/node - connect' | ||
| - '@sentry/node-native' | ||
| - '@sentry/angular' | ||
| - '@sentry/astro' | ||
| - '@sentry/aws-serverless' | ||
| - '@sentry/bun' | ||
| - '@sentry/cloudflare' | ||
| - '@sentry/cloudflare - hono' | ||
| - '@sentry/deno' | ||
| - '@sentry/ember' | ||
| - '@sentry/gatsby' | ||
| - '@sentry/google-cloud-serverless' | ||
| - '@sentry/nestjs' | ||
| - '@sentry/nextjs' | ||
| - '@sentry/nuxt' | ||
| - '@sentry/react' | ||
| - '@sentry/react-router' | ||
| - '@sentry/remix' | ||
| - '@sentry/solid' | ||
| - '@sentry/solidstart' | ||
| - '@sentry/svelte' | ||
| - '@sentry/sveltekit' | ||
| - '@sentry/tanstackstart-react' | ||
| - '@sentry/vue' | ||
| - '@sentry/wasm' | ||
| - Sentry NPM package | ||
| - Sentry Browser Loader | ||
| - Sentry Browser CDN bundle | ||
| validations: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Changing the issue template label from Which SDK are you using? will break the regex in the issue-package-label.yml workflow, causing automated labeling to fail.
Severity: HIGH
Suggested Fix
Update the regex in .github/workflows/issue-package-label.yml to match the new label text. Additionally, either update the workflow's mapping logic to handle the new generic dropdown options or revert the options to the specific package names the workflow expects.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/ISSUE_TEMPLATE/bug.yml#L25-L36
Potential issue: The `.github/workflows/issue-package-label.yml` workflow uses a regex
to find the heading `### Which SDK are you using?` in new issues to automatically apply
labels. This pull request changes the corresponding label in the `bug.yml` issue
template to `Where are you installing the Sentry SDK from?`. This mismatch will cause
the regex to fail for all new issues, breaking the automated labeling and triage
process. Furthermore, the new dropdown options are too generic for the workflow's
mapping logic, which expects specific package names.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreiborza that one is a good catch though
Inspired by https://github.com/remix-run/react-router/blob/8cb826426cf89ef6d89f84339ea4b90e60d2a34d/.github/ISSUE_TEMPLATE/bug_report.yml?plain=1#L45-L63
Closes #18992 (added automatically)