Overlay: Bump minimum CLI version for overlay#3353
Conversation
d7d0372 to
efbc56d
Compare
There was a problem hiding this comment.
Pull request overview
This PR bumps the minimum CodeQL CLI version required for overlay analysis from 2.23.5 to 2.23.8, aiming to reduce the number of CLI versions in use.
Key Changes:
- Updates the
CODEQL_OVERLAY_MINIMUM_VERSIONconstant from "2.23.5" to "2.23.8" in the source file - Regenerated JavaScript files in the
lib/directory reflect this change
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/overlay-database-utils.ts | Updates the minimum CLI version constant for overlay database functionality |
| lib/upload-sarif-action.js | Auto-generated JavaScript reflecting the source change |
| lib/upload-sarif-action-post.js | Auto-generated JavaScript reflecting the source change |
| lib/upload-lib.js | Auto-generated JavaScript reflecting the source change |
| lib/start-proxy-action.js | Auto-generated JavaScript reflecting the source change |
| lib/start-proxy-action-post.js | Auto-generated JavaScript reflecting the source change |
| lib/setup-codeql-action.js | Auto-generated JavaScript reflecting the source change |
| lib/resolve-environment-action.js | Auto-generated JavaScript reflecting the source change |
| lib/init-action.js | Auto-generated JavaScript reflecting the source change |
| lib/init-action-post.js | Auto-generated JavaScript reflecting the source change |
| lib/autobuild-action.js | Auto-generated JavaScript reflecting the source change |
| lib/analyze-action.js | Auto-generated JavaScript reflecting the source change |
| lib/analyze-action-post.js | Auto-generated JavaScript reflecting the source change |
Review Notes:
The change is straightforward and correct. The version bump from 2.23.5 to 2.23.8 is valid - version 2.23.8 was already set as the default CodeQL bundle version in release 4.31.8 (as documented in CHANGELOG.md). This version constant is used to determine the minimum CLI version for overlay analysis features, and bumping it aligns with reducing CLI version diversity. All generated JavaScript files in lib/ correctly reflect the TypeScript source change, as expected per the repository's custom guidelines.
Bump minimum CLI version for overlay analysis to reduce number of CLI versions in use.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, CCR, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
github.com.How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist