doc: add details for July 2022 security releases#43733
Closed
BethGriggs wants to merge 4 commits intonodejs:mainfrom
Closed
doc: add details for July 2022 security releases#43733BethGriggs wants to merge 4 commits intonodejs:mainfrom
BethGriggs wants to merge 4 commits intonodejs:mainfrom
Conversation
RafaelGSS
approved these changes
Jul 8, 2022
Member
RafaelGSS
left a comment
There was a problem hiding this comment.
LGTM. I would also mention the https://nodejs.org/en/blog/vulnerability/july-2022-security-releases/ post since it contains more detailed information and missing pieces in the changelog such as: "Attempt to read openssl.cnf from /home/iojs/build/ upon startup" and "DNS rebinding in --inspect via invalid IP addresses"
addaleax
reviewed
Jul 8, 2022
Member
Author
|
@addaleax, thank you for the suggestions. Sorry! I was working on some edits at the same time. I'll manually review all of your suggestions and apply |
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
mhdawson
reviewed
Jul 8, 2022
mhdawson
reviewed
Jul 8, 2022
addaleax
approved these changes
Jul 11, 2022
richardlau
approved these changes
Jul 11, 2022
BethGriggs
added a commit
that referenced
this pull request
Jul 11, 2022
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com> PR-URL: #43733 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com>
Member
Author
|
Landed in 15bb82b |
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com> PR-URL: #43733 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copy as appropriate to Node.js 16/14 changelogs once content has been reviewed--openssl-shared-configflag.I think providing the additional information in the changelogs would be useful (even if retroactive). Also, indicate the breaking changes as such.
cc: @RafaelGSS (I'll also add as co-author as a lot of this is copying your text.)