test: fix test-v8-collect-gc-profile-in-worker.js#46735
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Feb 24, 2023
Merged
Conversation
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Feb 19, 2023
github-actions
bot
removed
the
request-ci
Collaborator
24 tasks
jasnell
approved these changes
Feb 20, 2023
cjihrig
approved these changes
Feb 20, 2023
Collaborator
This was referenced Feb 21, 2023
Collaborator
31 tasks
theanarkh
added
the
author ready
Contributor
Author
|
Why |
theanarkh
force-pushed
the
fix_test-v8-collect-gc-profile-in-worker.js
branch
from
528928a to
d3d115d
Compare
github-actions
bot
removed
the
request-ci
Collaborator
25 tasks
Collaborator
theanarkh
added
the
commit-queue
tniessen
approved these changes
Feb 24, 2023
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in b3663e0 |
28 tasks
15 tasks
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46735 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46735 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix
test-v8-collect-gc-profile-in-worker.js.make -j4 test(UNIX), orvcbuild test(Windows) passes