lib: add trailing commas to all public core modules#46848
Merged
aduh95 merged 1 commit intonodejs:mainfrom Feb 28, 2023
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
debadree25
approved these changes
Feb 26, 2023
MoLow
reviewed
Feb 26, 2023
| - ./fs.js | ||
| - ./internal/assert.js | ||
| - ./internal/child_process.js | ||
| - ./*.js |
Member
There was a problem hiding this comment.
just confirming, this is not recursive, right?
Contributor
Author
There was a problem hiding this comment.
It's not, there are still 247 missing trailing commas files inside subdirs of lib/internal (my understanding is that * matches any char but the path separator, and ** would match any char including the path separator).
MoLow
approved these changes
Feb 26, 2023
aduh95
added
author ready
apapirovski
approved these changes
Feb 26, 2023
benjamingr
approved these changes
Feb 26, 2023
RafaelGSS
approved these changes
Feb 26, 2023
gengjiawen
approved these changes
Feb 27, 2023
trivikr
approved these changes
Feb 27, 2023
ZYSzys
approved these changes
Feb 27, 2023
debadree25
added
the
commit-queue
aduh95
removed
the
commit-queue
PR-URL: nodejs#46848 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
aduh95
force-pushed
the
public-dangle
branch
from
fb82072 to
9dbb162
Compare
Contributor
Author
|
Landed in 9dbb162 |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46848 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
PR-URL: #46848 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46848 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once this has landed, the next step would be to remove the overrides and have the rule applied on the whole
libfolder.