Fix frames-per-second parsing #7
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calculation of the throttle time based on `fps` option was the wrong way round so that *decreasing* the fps (which *should* result in fewer renders) actually caused the render rate to increase. A `fps` of 10 should result in a timeout value of 100ms, but as the code was previously it resulted in a timeout of 0.01ms, which effectively meant that there was no throttling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculation of the throttle time based on
fpsoption was the wrong way round so that decreasing the fps (which should result in fewer renders) actually caused the render rate to increase.A
fpsof 10 should result in a timeout value of 100ms, but as the code was previously it resulted in a timeout of 0.01ms, which effectively meant that there was no throttling.