Add toIndex versions for indexOf()#48
Merged
patrickfav merged 1 commit intopatrickfav:masterfrom Sep 3, 2022
Merged
Conversation
Owner
|
Thanks for the PR! Will try to release ASAP! |
Contributor
Author
|
@patrickfav Any news on the release? :) |
Owner
|
Hopefully this weekend, need find time to adapt jcenter releasing to maven central releasing |
Contributor
Author
|
@patrickfav No rush, just keeping in touch. Thanks for the response 👌🏻 |
Contributor
Author
|
@patrickfav friendly ping |
Owner
|
Sorry took me way longer, needed to migrate various tools, but here it is: https://github.com/patrickfav/bytes-java/releases/tag/v1.6.0 |
Contributor
Author
|
@patrickfav Thanks for the update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Patrick,
I've had a number of occasions when I found myself in need of a
toIndexversion ofindexOf. I happen to know particular windows in my byte arrays where the value is supposed to be.I'm leveraging existing functionality in
indexOf, just passing atoIndexinstead oflength().What do you think? Could this go into
1.5.1?Regards,
Herman.