feat: port Ubuntu versioning support to Debian container images #40499
+428
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pando85
force-pushed
the
feat/support-debian-versioning
branch
6 times, most recently
from
107cb22 to
c0df406
Compare
pando85
force-pushed
the
feat/support-debian-versioning
branch
3 times, most recently
from
a3a1327 to
c3845a4
Compare
Author
|
I added a small test to cover the two lines that were missing. It should be ready to merge now. |
Resolves renovatebot#27862. Signed-off-by: Alexander Gil <pando855@gmail.com>
pando85
force-pushed
the
feat/support-debian-versioning
branch
5 times, most recently
from
5b0e3b5 to
03831d6
Compare
Signed-off-by: Alexander Gil <pando855@gmail.com>
pando85
force-pushed
the
feat/support-debian-versioning
branch
from
03831d6 to
7f649d7
Compare
Author
|
Finally, all green. Ping @viceice |
| ${'buster-20220101'} | ${'buster'} | ||
| ${'bullseye-20220101'} | ${'bullseye'} | ||
| ${'bookworm-20230816'} | ${'bookworm'} | ||
| ${'bookworm-20230816.1'} | ${'bookworm'} |
Collaborator
There was a problem hiding this comment.
here we return the codename but in the previous isDatedCodename we return false for buster-20220101.123..why this difference ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #27862.
Changes
Added support for dated container image version formats in Debian versioning, similar to existing Ubuntu support. This includes parsing, validation, stability checks, and comparison logic for versions like
bookworm-20230816andbullseye-20220101.2.Key changes:
isDatedCodeNameto validate codenames against Debian distro infoDebianVersioningApiwith dated version handling inisValid,isStable,_parse,equals, andisGreaterThanContext
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: N/A (local development)